Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transceiver module temp thresholds #948

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add transceiver module temp thresholds #948

merged 1 commit into from
Sep 13, 2023

Conversation

dplore
Copy link
Member

@dplore dplore commented Aug 30, 2023 •
edited
Loading

Change Scope

  • Add upper and lower temperature thresholds for transceiver modules.
  • This change is backwards compatible.

Platform Implementations

Model tree view

        |  +--rw oc-transceiver:thresholds
        |     +--ro oc-transceiver:threshold* [severity]
        |        +--ro oc-transceiver:severity    -> ../state/severity
        |        +--ro oc-transceiver:state
        |           +--ro oc-transceiver:severity?                   identityref
        |           +--ro oc-transceiver:laser-temperature-upper?    decimal64
        |           +--ro oc-transceiver:laser-temperature-lower?    decimal64
        |           +--ro oc-transceiver:output-power-upper?         decimal64
        |           +--ro oc-transceiver:output-power-lower?         decimal64
        |           +--ro oc-transceiver:input-power-upper?          decimal64
        |           +--ro oc-transceiver:input-power-lower?          decimal64
        |           +--ro oc-transceiver:laser-bias-current-upper?   decimal64
        |           +--ro oc-transceiver:laser-bias-current-lower?   decimal64
        |           +--ro oc-transceiver:supply-voltage-upper?       decimal64
        |           +--ro oc-transceiver:supply-voltage-lower?       decimal64
        |           +--ro oc-transceiver:module-temperature-lower?   decimal64   <-- added
        |           +--ro oc-transceiver:module-temperature-upper?   decimal64   <--added

@dplore dplore requested a review from a team as a code owner August 30, 2023 18:45
@OpenConfigBot
Copy link

Major YANG version changes in commit ed8cec8:

@OpenConfigBot
Copy link

Compatibility Report for commit ed8cec8:
✅ pyangbind@6b85c2b

aashaikh
aashaikh approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@aashaikh aashaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see my question/suggestion re naming of these leaves. LGTM otherwise.

release/models/platform/openconfig-platform-transceiver.yang
@@ -843,6 +849,22 @@ module openconfig-platform-transceiver {
}
units volts;
}
leaf module-temperature-lower {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any significance to "module" here? Can this just be temperature-low and temperature-high?

Copy link
Member Author

@dplore dplore Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used module-temperature-* to differentiate from laser-temperature-*. Another wording that was considered was 'case-temperature'. It seems like temperature-* may be ambiguous since we are starting to see multiple temperature sensors on some transceiver modules (notably laser-temperature). @ejbrever for any additional comments.

@sulrich
Copy link
Contributor

sulrich commented Sep 7, 2023

@jnelson-sj @rolandphung for viz

@dplore dplore merged commit 1196fbf into master Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashaikh aashaikh aashaikh approved these changes

Assignees

@robshakir robshakir

Labels
non-breaking
Projects
OC Operator Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplore @OpenConfigBot @sulrich @aashaikh @robshakir